Hi Jean,
On 12/10/19 5:31 PM, Jean-Philippe Brucker wrote:
> Hi Eric,
>
> On Fri, Nov 22, 2019 at 07:29:25PM +0100, Eric Auger wrote:
>> +typedef struct VirtIOIOMMU {
>> + VirtIODevice parent_obj;
>> + VirtQueue *req_vq;
>> + VirtQueue *event_vq;
>> + struct virtio_iommu_config config;
>> + uint64_t features;
>> + uint64_t acked_features;
>
> We already have guest_features in the parent object.
That's correct. I also removed the set_features() specific
implementation as I can rely on the default one.
>
>> + GHashTable *as_by_busptr;
>> + IOMMUPciBus *as_by_bus_num[IOMMU_PCI_BUS_MAX];
>
> Doesn't seem used anymore.
removed
>
> Thanks,
> Jean
>
>> + PCIBus *primary_bus;
>> + GTree *domains;
>> + QemuMutex mutex;
>> + GTree *endpoints;
>> +} VirtIOIOMMU;
>> +
>> +#endif
>> --
>> 2.20.1
>>
>>
>
Thanks
Eric
