On Wed, Dec 18, 2019 at 06:19:57PM +0100, Philippe Mathieu-Daudé wrote:
> The Chardev events are listed in the QEMUChrEvent enum. To be
> able to use this enum in the IOEventHandler typedef, we need to
> explicit all the events ignored by this frontend, to silent the
> following GCC warning:
>
> hw/ipmi/ipmi_bmc_extern.c: In function ‘chr_event’:
> hw/ipmi/ipmi_bmc_extern.c:389:5: error: enumeration value ‘CHR_EVENT_BREAK’
> not handled in switch [-Werror=switch]
> 389 | switch (event) {
> | ^~~~~~
> hw/ipmi/ipmi_bmc_extern.c:389:5: error: enumeration value
> ‘CHR_EVENT_MUX_IN’ not handled in switch [-Werror=switch]
> hw/ipmi/ipmi_bmc_extern.c:389:5: error: enumeration value
> ‘CHR_EVENT_MUX_OUT’ not handled in switch [-Werror=switch]
> cc1: all warnings being treated as errors
Obviously a no-op, but better style. This is fine.
Acked-by: Corey Minyard <[email protected]>
>
> Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
> ---
> v2: Add all missing enums
>
> Cc: Corey Minyard <[email protected]>
> ---
> hw/ipmi/ipmi_bmc_extern.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/hw/ipmi/ipmi_bmc_extern.c b/hw/ipmi/ipmi_bmc_extern.c
> index 450926e5fb..adf2afe728 100644
> --- a/hw/ipmi/ipmi_bmc_extern.c
> +++ b/hw/ipmi/ipmi_bmc_extern.c
> @@ -435,6 +435,12 @@ static void chr_event(void *opaque, int event)
> k->handle_rsp(s, ibe->outbuf[0], ibe->inbuf + 1, 3);
> }
> break;
> +
> + case CHR_EVENT_BREAK:
> + case CHR_EVENT_MUX_IN:
> + case CHR_EVENT_MUX_OUT:
> + /* Ignore */
> + break;
> }
> }
>
> --
> 2.21.0
>
