On 12/12/19 17:11, Sergio Lopez wrote: >> } >> >> - if (kvm_check_extension(s, KVM_CAP_X86_SMM) && >> + if ( >> +#ifdef CONFIG_PC >> + kvm_check_extension(s, KVM_CAP_X86_SMM) && >> object_dynamic_cast(OBJECT(ms), TYPE_PC_MACHINE) && >> - pc_machine_is_smm_enabled(PC_MACHINE(ms))) { >> + pc_machine_is_smm_enabled(PC_MACHINE(ms)) >> +#else >> + 0 >> +#endif >> + ) { >> smram_machine_done.notify = register_smram_listener; >> qemu_add_machine_init_done_notifier(&smram_machine_done); >> } > I'm not familiar with SMM, can we consider it a PC specific thing? If it > isn't, perhaps we should move smm to X86MachineState.
Ok, I will do that. Paolo
signature.asc
Description: OpenPGP digital signature