On 05/12/2019 05:26, Alexey Kardashevskiy wrote: > > > On 04/12/2019 21:32, Laurent Vivier wrote: >> On 04/12/2019 05:40, Alexey Kardashevskiy wrote: >>> >>> >>> On 04/12/2019 15:23, Alexey Kardashevskiy wrote: >>>> >>>> >>>> On 04/12/2019 03:09, Laurent Vivier wrote: >>>>> >>>>> Bad reply, the problem is with >>>>> >>>>> "spapr: Render full FDT on ibm,client-architecture-support" >>>> >>>> >>>> https://git.qemu.org/?p=SLOF.git;a=blob;f=board-qemu/slof/fdt.fs;h=3e4c1b34b8af2dcebde57e548c94417e5e20e1cc;hb=HEAD#l265 >>>> >>>> A "bit ugly" became really ugly as before we were only patching >>>> interrupt-map for PHB (7 cells per line) only but now we have to patch >>>> (or, rather, skip) the PCI bridge interrupt-map (9 cells per line). >>>> >>>> Fixing now... >>> >>> >>> Basically, this: >>> >>> >>> diff --git a/board-qemu/slof/fdt.fs b/board-qemu/slof/fdt.fs >>> index 3e4c1b34b8af..463a2a8c0c2d 100644 >>> --- a/board-qemu/slof/fdt.fs >>> +++ b/board-qemu/slof/fdt.fs >>> @@ -300,8 +300,13 @@ fdt-claim-reserve >>> \ ." Replacing in " dup node>path type cr >>> >r >>> s" interrupt-map" r@ get-property 0= IF >>> - ( old new prop-addr prop-len R: node ) >>> - fdt-replace-interrupt-map >>> + dup e00 = IF >>> + ( old new prop-addr prop-len R: node ) >>> + fdt-replace-interrupt-map >>> + ELSE >>> + 2drop >>> + ." no idea what this is" cr >>> + THEN >>> THEN >> >> This does not fix the problem for me. > > That's strange, does it crash the same way?
No, you're right. I didn't test the good image. I've re-tested correctly and it works. > > Anyway I made 2 patches: > https://patchwork.ozlabs.org/patch/1204467/ > https://patchwork.ozlabs.org/patch/1204468/ > > Please give them a try. Thanks, I've applied them in series and after the second is applied all works fine. Thanks, Laurent
