On Mon, 2 Dec 2019 17:40:07 +0100 Cornelia Huck <[email protected]> wrote:
> On Sat, 30 Nov 2019 20:42:39 +0100 > Markus Armbruster <[email protected]> wrote: > > > Cc: Halil Pasic <[email protected]> > > Cc: Cornelia Huck <[email protected]> > > Cc: Christian Borntraeger <[email protected]> > > Signed-off-by: Markus Armbruster <[email protected]> > > --- > > hw/intc/s390_flic_kvm.c | 10 ++++------ > > 1 file changed, 4 insertions(+), 6 deletions(-) > > Reviewed-by: Cornelia Huck <[email protected]> > > ...someone else wants to take a look before I queue this? > I guess it is a matter of taste. Acked-by: Halil Pasic <[email protected]> The only difference I can see is if the **errp argument where to already contain an error (*errp). I guess the old code would just keep the first error, and discard the next one, while error_setv() does an assert(*errp == NULL). I assume calling with *errp != NULL is not a valid scenario. But then, I can't say I understand the use-case behind this discard the newer error behavior of error_propagate(). Regards, Halil
