Am 25.11.2019 um 16:06 hat Alberto Garcia geschrieben:
> On Fri 22 Nov 2019 05:05:05 PM CET, Kevin Wolf wrote:
>
> > @@ -3405,6 +3412,7 @@ typedef struct TruncateCo {
> > int64_t offset;
> > bool exact;
> > PreallocMode prealloc;
> > + bool no_fallback;
> > Error **errp;
> > int ret;
> > } TruncateCo;
>
> You add the 'no_fallback' field here...
>
> > int bdrv_truncate(BdrvChild *child, int64_t offset, bool exact,
> > - PreallocMode prealloc, Error **errp)
> > + PreallocMode prealloc, bool no_fallback, Error **errp)
> > {
> > Coroutine *co;
> > TruncateCo tco = {
>
> ...but then you don't use it when the structure is initialized.
Oops. Another proof that a series like this is too much for -rc3.
Kevin
