Hi On Mon, Nov 18, 2019 at 6:01 PM Peter Maydell <[email protected]> wrote: > > On Wed, 23 Oct 2019 at 18:32, Marc-André Lureau > <[email protected]> wrote: > > > > Signed-off-by: Marc-André Lureau <[email protected]> > > --- > > hw/core/qdev-properties.c | 32 -------------------------------- > > include/hw/qdev-properties.h | 3 --- > > 2 files changed, 35 deletions(-) > > I think I'd rather keep this. It's weird to not have a symmetric > set of properties for the common integer types, and annoying > for whoever next runs into a need for an int64 property to > have to reinstate the deleted code. (Yes, I know we don't > currently have int8 or int16.) >
I don't think we should aim at being complete. Whenever we identify dead code, unused for a long while, we should clean it up. In this case, it is even worse, this has never been used since its introduction in commit 07d1d063d3235c02f60dc92ec174d419e6f8a750, in 2017.
