On Wed, 23 Oct 2019 at 18:34, Marc-André Lureau
<[email protected]> wrote:
>
> And a property and rename "it_shift" field to "regshift", as it seems
> to be more popular (and I don't know what "it" stands for).
>
> Signed-off-by: Marc-André Lureau <[email protected]>
I have no idea what it_shift means either (I had a look in the
git history but it seems to have been added with that name
very early on when the commit logs were generally not very
informative); 'regshift' sounds good to me too.
> +static Property serial_mm_properties[] = {
> + DEFINE_PROP_UINT8("regshift", SerialMM, regshift, 0),
This could use a comment describing what the property does.
> + DEFINE_PROP_END_OF_LIST(),
Otherwise
Reviewed-by: Peter Maydell <[email protected]>
thanks
-- PMM
