Re: [PATCH for-5.0 7/8] ppc/pnv: Link "chip" property to PnvCore::chip pointer

[Greg Kurz]

On Fri, 15 Nov 2019 13:24:50 +0100
Cédric Le Goater <c...@kaod.org> wrote:

> > diff --git a/include/hw/ppc/pnv_core.h b/include/hw/ppc/pnv_core.h
> > index 55eee95104da..fce6d8d9b31b 100644
> > --- a/include/hw/ppc/pnv_core.h
> > +++ b/include/hw/ppc/pnv_core.h
> > @@ -36,11 +36,11 @@ typedef struct PnvChip PnvChip;
> >  typedef struct PnvCore {
> >      /*< private >*/
> >      CPUCore parent_obj;
> > +    PnvChip *chip;
> >  
> >      /*< public >*/
> >      PowerPCCPU **threads;
> >      uint32_t pir;
> > -    PnvChip *chip;
> >  
> >      MemoryRegion xscom_regs;
> >  } PnvCore;
> > 
> 
> 
> Why this change ? 
> 

Because PnvCore::chip is an PnvCore internal that shouldn't be
used outside pnv_core.c IMHO.

> C.