On Tue, Nov 05, 2019 at 04:12:09PM +0100, Philippe Mathieu-Daudé wrote: > When hw/$DIR/Kconfig is changed, the corresponding generated > hw/$DIR/config-devices.mak is not being updated. > Fix this by including all the hw/*/Kconfig files to the prerequisite > names of the rule generating the config-devices.mak files. > > Fixes: e0e312f3525a (build: switch to Kconfig) > Reported-by: Peter Maydell <[email protected]> > Suggested-by: Daniel P. Berrangé <[email protected]> > Signed-off-by: Philippe Mathieu-Daudé <[email protected]> > --- > v2: > Simplify using the wildcard() function instead of calling `sed` (danpb) > > You can see this tread where Peter reported the failure: > https://lists.gnu.org/archive/html/qemu-devel/2019-11/msg00125.html > > How to reproduce: > > $ git checkout branch_modifying_kconfig > $ make i386-softmmu/all > $ make clean > $ git checkout prev_branch > $ make clean > $ make i386-softmmu/all > # error > > If OK, I plan to include this fix in the "hw/i386/pc: Split PIIX3 > southbridge from i440FX northbridge" pull request. > --- > Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <[email protected]> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
