On 10/25/19 1:39 PM, Richard Henderson wrote:
The error indicator for this syscall is -1, not 0.

Reviewed-by: Laurent Vivier <[email protected]>
Signed-off-by: Richard Henderson <[email protected]>
---
  tests/tcg/multiarch/linux-test.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/tcg/multiarch/linux-test.c b/tests/tcg/multiarch/linux-test.c
index fa4243fc04..673d7c8a1c 100644
--- a/tests/tcg/multiarch/linux-test.c
+++ b/tests/tcg/multiarch/linux-test.c
@@ -503,8 +503,9 @@ static void test_shm(void)
shmid = chk_error(shmget(IPC_PRIVATE, SHM_SIZE, IPC_CREAT | 0777));
      ptr = shmat(shmid, NULL, 0);
-    if (!ptr)
+    if (ptr == (void *)-1) {

Oops.

Reviewed-by: Philippe Mathieu-Daudé <[email protected]>

          error("shmat");
+    }
memset(ptr, 0, SHM_SIZE);


Reply via email to