On 10/20/19 1:47 PM, Sven Schnelle wrote:
> #define DINO_PCI_HOST_BRIDGE(obj) \
> OBJECT_CHECK(DinoState, (obj), TYPE_DINO_PCI_HOST_BRIDGE)
>
> +#define DINO800_REGS ((DINO_TLTIM - DINO_GMASK) / 4)
> +static uint8_t reg800_keep_bits[DINO800_REGS]
> + = { 1, 7, 7, 8, 7, 9, 32, 8, 30, 25, 22, 9 };
(1) const.
(2) better as a mask:
static const uint32_t reg800_keep_mask[DINO800_REGS] = {
MAKE_64BIT_MASK(0, 1),
MAKE_64BIT_MASK(0, 7),
...
};
since that's the only way this is actually used.
r~
