On 10/21/19 1:57 AM, David Hildenbrand wrote:
> The numbers are unsigned, the computation is wrong. "Each operand is
> treated as an unsigned binary integer".
> Let's implement as given in the PoP:
>
> "A subtraction is performed by adding the contents of the second operand
> with the bitwise complement of the third operand along with a borrow
> indication from the rightmost bit of the fourth operand."
>
> Reuse gen_accc2_i64().
>
> Fixes: bc725e65152c ("s390x/tcg: Implement VECTOR SUBTRACT WITH BORROW
> COMPUTE BORROW INDICATION")
> Signed-off-by: David Hildenbrand <[email protected]>
> ---
> target/s390x/translate_vx.inc.c | 13 +++----------
> 1 file changed, 3 insertions(+), 10 deletions(-)
Reviewed-by: Richard Henderson <[email protected]>
r~
