On Mon, 14 Oct 2019 at 17:05, Peter Maydell <[email protected]> wrote:
>
> From: Cédric Le Goater <[email protected]>
>
> Signed-off-by: Cédric Le Goater <[email protected]>
> Reviewed-by: Joel Stanley <[email protected]>
> Message-id: [email protected]
> Signed-off-by: Peter Maydell <[email protected]>
> ---
> include/hw/arm/aspeed.h | 1 +
> hw/arm/aspeed.c | 23 +++++++++++++++++++++++
> 2 files changed, 24 insertions(+)
> @@ -455,6 +467,17 @@ static const AspeedBoardConfig aspeed_boards[] = {
> .num_cs = 2,
> .i2c_init = witherspoon_bmc_i2c_init,
> .ram = 512 * MiB,
> + }, {
> + .name = MACHINE_TYPE_NAME("ast2600-evb"),
> + .desc = "Aspeed AST2600 EVB (Cortex A7)",
> + .soc_name = "ast2600-a0",
> + .hw_strap1 = AST2600_EVB_HW_STRAP1,
> + .hw_strap2 = AST2600_EVB_HW_STRAP2,
> + .fmc_model = "w25q512jv",
> + .spi_model = "mx66u51235f",
> + .num_cs = 1,
> + .i2c_init = ast2600_evb_i2c_init,
> + .ram = 2 * GiB,
Hi. I just discovered that this makes 'make check' fail on
32-bit systems, because you can't default to 2GB of RAM
for a board:
(armhf)pmaydell@mustang-maydell:~/qemu$
./build/all-a32/arm-softmmu/qemu-system-arm -M ast2600-evb
qemu-system-arm: at most 2047 MB RAM can be simulated
It's also a pretty rudely large amount of RAM to allocate
by default: it caused 'make check' to fail on my OSX
box, which is 64-bits but doesn't have huge swathes
of free RAM.
I'm going to drop this patch from my queue and redo
the pullreq.
thanks
-- PMM
