Peter Xu <pet...@redhat.com> wrote: > It was "int" and used as 32bits fields (see save_section_header()). > It's unsafe already because sizeof(int) could be 2 on i386,
i386 is 32bits, so int is 32bits O:-) I really hope that we would never, ever, need a 64bits instance id. It would mean that we have more than 2.000.000.000 objects of the same type, no? I am pretty sure than in 16bits platforms we have other problems than insntance_id (namely that we don't have enough memory). >I think. > So at least uint32_t would suite more. While it also uses "-1" as a > placeholder of "we want to generate the instance ID automatically". > Hence a more proper value should be int64_t. > > This will start to be useful after next patch in which we can start to > convert a real uint32_t value as instance ID. Later, Juan.
