On 10/9/19 3:51 PM, Stefan Hajnoczi wrote:
tracetool needs to know the group name ("all", "root", or a specific
subdirectory).  Also remove the stdin redirection because tracetool.py
needs the path to the trace-events file.  Update the documentation.

Thanks!


Fixes: 2098c56a9bc5901e145fa5d4759f075808811685
        ("trace: move setting of group name into Makefiles")
Launchpad: https://bugs.launchpad.net/bugs/1844814
Reported-by: Philippe Mathieu-Daudé <[email protected]>
Cc: Daniel P. Berrange <[email protected]>
Signed-off-by: Stefan Hajnoczi <[email protected]>
---
  docs/devel/tracing.txt | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/docs/devel/tracing.txt b/docs/devel/tracing.txt
index 8231bbf5d1..8c0376fefa 100644
--- a/docs/devel/tracing.txt
+++ b/docs/devel/tracing.txt
@@ -317,7 +317,8 @@ probes:
                           --binary path/to/qemu-binary \
                           --target-type system \
                           --target-name x86_64 \
-                         <trace-events-all >qemu.stp
+                         --group=all \
+                         trace-events-all >qemu.stp
To facilitate simple usage of systemtap where there merely needs to be printf
  logging of certain probes, a helper script "qemu-trace-stap" is provided.


Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
Tested-by: Philippe Mathieu-Daudé <[email protected]>

Reply via email to