On 08/10/2019 11.48, Stefano Garzarella wrote: > Hi Thomas, > > On Tue, Oct 8, 2019 at 10:49 AM Thomas Huth <th...@redhat.com> wrote: >> >> FreeBSD offers a package for "netmap", thus let's install it in our >> FreeBSD tests to get some compile test coverage for net/netmap.c, too. >> >> Signed-off-by: Thomas Huth <th...@redhat.com> >> --- >> .cirrus.yml | 2 +- >> tests/vm/freebsd | 3 +++ >> 2 files changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/.cirrus.yml b/.cirrus.yml >> index 8326a3a4b1..44fea2c29e 100644 >> --- a/.cirrus.yml >> +++ b/.cirrus.yml >> @@ -8,7 +8,7 @@ freebsd_12_task: >> memory: 8G >> install_script: pkg install -y >> bash bison curl cyrus-sasl git glib gmake gnutls gsed >> - nettle perl5 pixman pkgconf png usbredir >> + netmap nettle perl5 pixman pkgconf png usbredir > >> script: >> - mkdir build >> - cd build >> diff --git a/tests/vm/freebsd b/tests/vm/freebsd >> index 2a19461a90..45821702bd 100755 >> --- a/tests/vm/freebsd >> +++ b/tests/vm/freebsd >> @@ -54,6 +54,9 @@ class FreeBSDVM(basevm.BaseVM): >> # libs: opengl >> "libepoxy", >> "mesa-libs", >> + >> + # libs: network >> + "netmap", > > IIRC netmap is shipped with the FreeBSD kernel, so we shouldn't need to > install it. > > I tried to understand what is the 'netmap' pkg and I found the following > in my FreeBSD 12 VM: > > # pkg search netmap > netmap-0.1.3_1 Make a graphical representation of the surrounding > network > > I don't think we are installing the right 'netmap' (I know, it is a bit > confusing :) ) > > I'll tried "make vm-build-freebsd" without this patch and I noticed > "netmap support yes" in the configure output. So I think we're > already compiling the netmap backend in the 'vm-buil-freebsd' target and > maybe also in cirrus.
Oops, I think you're right. I just checked an older build on cirrus-ci (without this patch), and indeed, it also says "netmap support yes" in the output of "configure". So we already have a compile test for netmap :-) Thus, please disregard this patch, it's not necessary indeed. Thomas
