On Fri, 4 Oct 2019 at 12:48, Peter Maydell <[email protected]> wrote:
>
> Provide the new transaction-based API.
> +void ptimer_transaction_begin(ptimer_state *s)
> +{
> + assert(!s->in_transaction && s->callback);
> + s->in_transaction = true;
As I was working on converting the ptimer tests to the new
API I noticed a silly bug here -- we should set
s->need_reload = false;
in ptimer_transaction_begin(). Otherwise one transaction has
decided to do a reload, we'll do a reload in commit every time,
including when that's bogus (eg when the timer is disabled)...
thanks
-- PMM
