From: Vladimir Sementsov-Ogievskiy <[email protected]> Enabled by default copy_range ignores compress option. It's definitely unexpected for user.
It's broken since introduction of copy_range usage in backup in 9ded4a011496. Signed-off-by: Vladimir Sementsov-Ogievskiy <[email protected]> Message-id: [email protected] Reviewed-by: John Snow <[email protected]> Reviewed-by: Max Reitz <[email protected]> Cc: [email protected] Signed-off-by: Max Reitz <[email protected]> (cherry picked from commit 110571be4e70ac015628e76d2731f96dd8d1998c) Signed-off-by: Michael Roth <[email protected]> --- block/backup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/backup.c b/block/backup.c index f67c208cf0..381659d5ef 100644 --- a/block/backup.c +++ b/block/backup.c @@ -666,7 +666,7 @@ BlockJob *backup_job_create(const char *job_id, BlockDriverState *bs, job->cluster_size = cluster_size; job->copy_bitmap = copy_bitmap; copy_bitmap = NULL; - job->use_copy_range = true; + job->use_copy_range = !compress; /* compression isn't supported for it */ job->copy_range_size = MIN_NON_ZERO(blk_get_max_transfer(job->common.blk), blk_get_max_transfer(job->target)); job->copy_range_size = MAX(job->cluster_size, -- 2.17.1
