On Mon, 23 Sep 2019 at 13:21, Thomas Huth <[email protected]> wrote: > > Everybody who used something like "-machine accel=kvm:tcg" in the past > might be tempted to specify a similar list with the -accel parameter, > too, for example "-accel kvm:tcg". However, this is not how this > options is thought to be used, since each "-accel" should only take care > of one specific accelerator. > > In the long run, we really should rework the "-accel" code completely, > so that it does not set "-machine accel=..." anymore internally, but > is completely independent from "-machine". For the short run, let's > make sure that users cannot use "-accel xyz:tcg", so that we avoid > that we have to deal with such cases in the wild later. > > Signed-off-by: Thomas Huth <[email protected]> > --- > vl.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/vl.c b/vl.c > index 630f5c5e9c..68f47a9c25 100644 > --- a/vl.c > +++ b/vl.c > @@ -3554,6 +3554,11 @@ int main(int argc, char **argv, char **envp) > g_slist_free(accel_list); > exit(0); > } > + if (optarg && strchr(optarg, ':')) { > + error_report("Don't use ':' with -accel, " > + "use -M accel=... in this case instead"); > + exit(1); > + }
This seems pretty ugly. If -accel is the way we're recommending users configure the accelerator then it should support syntax for specifying everything we could do with the old -machine... option. If it can't do that yet, we shouldn't switch over to it until it can. thanks -- PMM
