On 28/08/2019 15.48, Christian Borntraeger wrote: > > > On 28.08.19 15:47, Cornelia Huck wrote: >> On Wed, 28 Aug 2019 15:42:37 +0200 >> Thomas Huth <[email protected]> wrote: >> >>> On 28/08/2019 15.27, Christian Borntraeger wrote: >>>> On 28.08.19 14:33, Thomas Huth wrote: >>>>> We're clearing the BSS in start.S now, so there is no need to >>>>> pre-initialize the loadparm_str array with zeroes anymore. >>>> >>>> Can you add a link to the commit that does the bss clearing? >>> >>> Sure, I'll change the description to: >>> >>> " >>> Since commit 339686a358b11a231aa5b6d1424e7a1460d7f277 ("pc-bios/s390-ccw: >>> zero out bss section"), we are clearing now the BSS in start.S, so there >>> is no need to pre-initialize the loadparm_str array with zeroes anymore. >>> " > >>> >>> Thomas >> >> With that: >> >> Reviewed-by: Cornelia Huck <[email protected]> > > Acked-by: Christian Borntraeger <[email protected]> > > Thomas are you going to pick this up or shall I do it?
I don't mind either way. Not sure whether this patch justifies a bios rebuild, so I'd rather wait for some more time for other bios patches to show up. But if you want to pick it up (together with the "fix a possible memory leak in get_uuid" patch that is still pending), please go ahead. Thomas
