On 23.08.19 17:22, Richard Henderson wrote:
> On 8/23/19 3:07 AM, David Hildenbrand wrote:
>> +void probe_write(CPUArchState *env, target_ulong addr, int size, int
>> mmu_idx,
>> + uintptr_t retaddr)
>> +{
>> + CPUState *cpu = env_cpu(env);
>> + CPUClass *cc;
>> +
>> + if (!guest_addr_valid(addr) ||
>> + (size > 0 && !guest_addr_valid(addr + size - 1)) ||
>
> I think the interface needs to remain the same between softmmu and linux-user,
> and we should not allow size to cross a page here either. Which also means
> that the second line here can go away -- we only need the one test vs the
> single page.
Can do, and add the same g_assert.
Thanks!
--
Thanks,
David / dhildenb
