On 23/08/19 09:32, Marc-André Lureau wrote: > On Thu, Aug 22, 2019 at 9:43 PM Paolo Bonzini <pbonz...@redhat.com> wrote: >> >> $(call land, $(CONFIG_SPICE), $(CONFIG_GIO)) will never return "m" so >> ui-spice-app is always linked into QEMU. >> >> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > > I would rather build the module: > -common-obj-$(call land,$(CONFIG_SPICE),$(CONFIG_GIO)) += spice-app.mo > +ifeq ($(CONFIG_GIO)$(CONFIG_SPICE),yy) > +common-obj-$(if $(CONFIG_MODULES),m,y) += spice-app.mo > +endif
That would not be a quick patch that Peter can apply to fix the build... Paolo
