On 8/7/19 4:41 PM, Peter Maydell wrote: > On Mon, 29 Jul 2019 at 15:58, Damien Hedde <damien.he...@greensocs.com> wrote: >> >> >> +/** >> + * device_reset: >> + * Resets the device @dev, @cold tell whether to do a cold or warm reset. >> + * Base behavior is to reset the device and its qdev/qbus subtree. > > What do you mean by "base behavior" here? When would this ever > do anything else? > Oops, just noticed I missed this comment. Since I had to use a method "foreach_child" to call reset on children, the behavior depends on it. Default implementation in base classes follows the qdev tree. But a specialization can change that. That's more a side-effect than a wanted feature.
- [Qemu-devel] [PATCH v3 04/33] make Device and Bus Resettable Damien Hedde
- Re: [Qemu-devel] [PATCH v3 04/33] make Device and Bus R... David Gibson
- Re: [Qemu-devel] [PATCH v3 04/33] make Device and B... Damien Hedde
- Re: [Qemu-devel] [PATCH v3 04/33] make Device a... David Gibson
- Re: [Qemu-devel] [PATCH v3 04/33] make Devi... Damien Hedde
- Re: [Qemu-devel] [PATCH v3 04/33] make Device and Bus R... Peter Maydell
- Re: [Qemu-devel] [PATCH v3 04/33] make Device and B... Damien Hedde
- Re: [Qemu-devel] [PATCH v3 04/33] make Device a... Peter Maydell
- Re: [Qemu-devel] [PATCH v3 04/33] make Device and B... Damien Hedde
- [Qemu-devel] [PATCH v3 18/33] hw/audio/intel-hda.c: remove d... Damien Hedde
- [Qemu-devel] [PATCH v3 12/33] hw/pci/: remove qdev/qbus_rese... Damien Hedde
- [Qemu-devel] [PATCH v3 08/33] Add function to control reset ... Damien Hedde
- Re: [Qemu-devel] [PATCH v3 08/33] Add function to contr... David Gibson
- Re: [Qemu-devel] [PATCH v3 08/33] Add function to c... Damien Hedde
- Re: [Qemu-devel] [PATCH v3 08/33] Add function to c... Peter Maydell
- Re: [Qemu-devel] [PATCH v3 08/33] Add function ... David Gibson
- Re: [Qemu-devel] [PATCH v3 08/33] Add funct... Damien Hedde