On Mon, Aug 05, 2019 at 07:11:11AM +0000, Oleinik, Alexander wrote: > Signed-off-by: Alexander Oleinik <alx...@bu.edu> > --- > tests/libqtest.c | 61 ++++++++++++++++++++++++++++++++++++++++++++++-- > tests/libqtest.h | 6 +++++ > 2 files changed, 65 insertions(+), 2 deletions(-)
Please refactor the code instead of adding #ifdefs. Most of the code doesn't care whether it is communicating over a socket or in-process. > @@ -317,6 +323,21 @@ QTestState *qtest_initf(const char *fmt, ...) > return s; > } > > +#ifdef CONFIG_FUZZ > +QTestState *qtest_fuzz_init(const char *extra_args, int *sock_fd) This isn't really specific to fuzzing. It's just an in-process qtest client for QEMU. Please name it qtest_inproc_client_init() or similar.
signature.asc
Description: PGP signature
