Paolo Bonzini <pbonz...@redhat.com> writes:
> Avoid the repeated inclusions of config-target.mak, which have
> risks of namespace pollution, and instead build minimal configuration
> files in a configuration script. The same configuration files can
> also be included in Makefile and Makefile.qemu
>
<snip>
> diff --git a/configure b/configure
> index 714e7fb..b0bd308 100755
> --- a/configure
> +++ b/configure
<snip>
>
> if test "$libpmem" != "no"; then
> @@ -6516,6 +6468,12 @@ if ! $python -c 'import sys; sys.exit(sys.version_info
> < (3,0))'; then
> echo "warning: Python 3 will be required for building future versions of
> QEMU" >&2
> fi
>
> +(for i in $cross_cc_vars; do
> + export $i
> +done
> +export target_list source_path
> +${SHELL-/bin/sh} $source_path/tests/tcg/configure.sh)
> +
Do we really want to use the users SHELL here? What's wrong with just
calling it and letting the OS derive things from the #!?
--
Alex Bennée
