Patchew URL: https://patchew.org/QEMU/20190806151435.10740-1-arm...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v2 00/29] Tame a few "touch this, recompile the world" headers Message-id: 20190806151435.10740-1-arm...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu df1a7c9..bb15791 master -> master * [new tag] patchew/20190806151435.10740-1-arm...@redhat.com -> patchew/20190806151435.10740-1-arm...@redhat.com Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for path 'capstone' Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc' Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) registered for path 'roms/QemuMacDrivers' Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 'roms/SLOF' Submodule 'roms/edk2' (https://git.qemu.org/git/edk2.git) registered for path 'roms/edk2' Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 'roms/ipxe' Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered for path 'roms/openbios' Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) registered for path 'roms/openhackware' Submodule 'roms/opensbi' (https://git.qemu.org/git/opensbi.git) registered for path 'roms/opensbi' Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) registered for path 'roms/qemu-palcode' Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for path 'roms/seabios' Submodule 'roms/seabios-hppa' (https://git.qemu.org/git/seabios-hppa.git) registered for path 'roms/seabios-hppa' Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for path 'roms/sgabios' Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for path 'roms/skiboot' Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for path 'roms/u-boot' Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) registered for path 'roms/u-boot-sam460ex' Submodule 'slirp' (https://git.qemu.org/git/libslirp.git) registered for path 'slirp' Submodule 'tests/fp/berkeley-softfloat-3' (https://git.qemu.org/git/berkeley-softfloat-3.git) registered for path 'tests/fp/berkeley-softfloat-3' Submodule 'tests/fp/berkeley-testfloat-3' (https://git.qemu.org/git/berkeley-testfloat-3.git) registered for path 'tests/fp/berkeley-testfloat-3' Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) registered for path 'ui/keycodemapdb' Cloning into 'capstone'... Submodule path 'capstone': checked out '22ead3e0bfdb87516656453336160e0a37b066bf' Cloning into 'dtc'... Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536' Cloning into 'roms/QemuMacDrivers'... Submodule path 'roms/QemuMacDrivers': checked out '90c488d5f4a407342247b9ea869df1c2d9c8e266' Cloning into 'roms/SLOF'... Submodule path 'roms/SLOF': checked out 'ba1ab360eebe6338bb8d7d83a9220ccf7e213af3' Cloning into 'roms/edk2'... Submodule path 'roms/edk2': checked out '20d2e5a125e34fc8501026613a71549b2a1a3e54' Submodule 'SoftFloat' (https://github.com/ucb-bar/berkeley-softfloat-3.git) registered for path 'ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3' Submodule 'CryptoPkg/Library/OpensslLib/openssl' (https://github.com/openssl/openssl) registered for path 'CryptoPkg/Library/OpensslLib/openssl' Cloning into 'ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3'... Submodule path 'roms/edk2/ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037' Cloning into 'CryptoPkg/Library/OpensslLib/openssl'... Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl': checked out '50eaac9f3337667259de725451f201e784599687' Submodule 'boringssl' (https://boringssl.googlesource.com/boringssl) registered for path 'boringssl' Submodule 'krb5' (https://github.com/krb5/krb5) registered for path 'krb5' Submodule 'pyca.cryptography' (https://github.com/pyca/cryptography.git) registered for path 'pyca-cryptography' Cloning into 'boringssl'... Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl/boringssl': checked out '2070f8ad9151dc8f3a73bffaa146b5e6937a583f' Cloning into 'krb5'... Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl/krb5': checked out 'b9ad6c49505c96a088326b62a52568e3484f2168' Cloning into 'pyca-cryptography'... Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl/pyca-cryptography': checked out '09403100de2f6f1cdd0d484dcb8e620f1c335c8f' Cloning into 'roms/ipxe'... Submodule path 'roms/ipxe': checked out 'de4565cbe76ea9f7913a01f331be3ee901bb6e17' Cloning into 'roms/openbios'... Submodule path 'roms/openbios': checked out 'c79e0ecb84f4f1ee3f73f521622e264edd1bf174' Cloning into 'roms/openhackware'... Submodule path 'roms/openhackware': checked out 'c559da7c8eec5e45ef1f67978827af6f0b9546f5' Cloning into 'roms/opensbi'... Submodule path 'roms/opensbi': checked out 'ce228ee0919deb9957192d723eecc8aaae2697c6' Cloning into 'roms/qemu-palcode'... Submodule path 'roms/qemu-palcode': checked out 'bf0e13698872450164fa7040da36a95d2d4b326f' Cloning into 'roms/seabios'... Submodule path 'roms/seabios': checked out 'a5cab58e9a3fb6e168aba919c5669bea406573b4' Cloning into 'roms/seabios-hppa'... Submodule path 'roms/seabios-hppa': checked out '0f4fe84658165e96ce35870fd19fc634e182e77b' Cloning into 'roms/sgabios'... Submodule path 'roms/sgabios': checked out 'cbaee52287e5f32373181cff50a00b6c4ac9015a' Cloning into 'roms/skiboot'... Submodule path 'roms/skiboot': checked out '261ca8e779e5138869a45f174caa49be6a274501' Cloning into 'roms/u-boot'... Submodule path 'roms/u-boot': checked out 'd3689267f92c5956e09cc7d1baa4700141662bff' Cloning into 'roms/u-boot-sam460ex'... Submodule path 'roms/u-boot-sam460ex': checked out '60b3916f33e617a815973c5a6df77055b2e3a588' Cloning into 'slirp'... Submodule path 'slirp': checked out '126c04acbabd7ad32c2b018fe10dfac2a3bc1210' Cloning into 'tests/fp/berkeley-softfloat-3'... Submodule path 'tests/fp/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037' Cloning into 'tests/fp/berkeley-testfloat-3'... Submodule path 'tests/fp/berkeley-testfloat-3': checked out '5a59dcec19327396a011a17fd924aed4fec416b3' Cloning into 'ui/keycodemapdb'... Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce' Switched to a new branch 'test' 677e4b3 sysemu: Split sysemu/runstate.h off sysemu/sysemu.h 436bf3a sysemu: Move the VMChangeStateEntry typedef to qemu/typedefs.h 67065f5 Include sysemu/sysemu.h a lot less 1f54376 Clean up inclusion of sysemu/sysemu.h 0ade0fa numa: Move remaining NUMA declarations from sysemu.h to numa.h 28ea970 Include sysemu/hostmem.h less 7b81864 numa: Don't include hw/boards.h into sysemu/numa.h 9114ff0 Include hw/boards.h a bit less c72a86b Include hw/qdev-properties.h less dbce1e2 Include qemu/main-loop.h less 9db50e6 Include qemu/queue.h slightly less 3b9dd4c Include hw/hw.h exactly where needed 995920e Include qom/object.h slightly less 0fab68b Include exec/memory.h slightly less fdc2a89 Include migration/vmstate.h less efde008 migration: Move the VMStateDescription typedef to typedefs.h 2e3f4f8 Clean up inclusion of exec/cpu-common.h 1cb7b18 Include hw/irq.h a lot less 9614b14 typedefs: Separate incomplete types and function types b34b0ba ide: Include hw/ide/internal a bit less outside hw/ide/ ebb4460 Include migration/qemu-file-types.h a lot less dd59e0c Include sysemu/reset.h a lot less e92facf trace: Do not include qom/cpu.h into generated trace.h 07ead8f trace: Eliminate use of TARGET_FMT_plx dbc11b8 queue: Drop superfluous #include qemu/atomic.h 2b86100 memory: Fix type of IOMMUMemoryRegionClass member @parent_class ce4504a qapi: Split error.json off common.json 8ec58b9 Include generated QAPI headers less fbe2a3f include: Make headers more self-contained === OUTPUT BEGIN === 1/29 Checking commit fbe2a3f02fbd (include: Make headers more self-contained) 2/29 Checking commit 8ec58b94b7c4 (Include generated QAPI headers less) 3/29 Checking commit ce4504aae5b2 (qapi: Split error.json off common.json) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #104: new file mode 100644 total: 0 errors, 1 warnings, 96 lines checked Patch 3/29 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/29 Checking commit 2b86100fbd14 (memory: Fix type of IOMMUMemoryRegionClass member @parent_class) 5/29 Checking commit dbc11b8c6c8d (queue: Drop superfluous #include qemu/atomic.h) 6/29 Checking commit 07ead8faef0c (trace: Eliminate use of TARGET_FMT_plx) ERROR: Hex numbers must be prefixed with '0x' #32: FILE: hw/tpm/trace-events:4: +tpm_crb_mmio_read(uint64_t addr, unsigned size, uint32_t val) "CRB read 0x016%" PRIx64 " len:%u val: 0x%" PRIx32 total: 1 errors, 0 warnings, 19 lines checked Patch 6/29 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/29 Checking commit e92facf038e6 (trace: Do not include qom/cpu.h into generated trace.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #140: new file mode 100644 total: 0 errors, 1 warnings, 190 lines checked Patch 7/29 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/29 Checking commit dd59e0cb755d (Include sysemu/reset.h a lot less) 9/29 Checking commit ebb44604b965 (Include migration/qemu-file-types.h a lot less) 10/29 Checking commit b34b0bab44af (ide: Include hw/ide/internal a bit less outside hw/ide/) 11/29 Checking commit 9614b147f3ce (typedefs: Separate incomplete types and function types) 12/29 Checking commit 1cb7b1803949 (Include hw/irq.h a lot less) 13/29 Checking commit 2e3f4f8319f1 (Clean up inclusion of exec/cpu-common.h) 14/29 Checking commit efde008f278c (migration: Move the VMStateDescription typedef to typedefs.h) 15/29 Checking commit fdc2a8900f59 (Include migration/vmstate.h less) 16/29 Checking commit 0fab68b4d558 (Include exec/memory.h slightly less) 17/29 Checking commit 995920edf4c9 (Include qom/object.h slightly less) 18/29 Checking commit 3b9dd4cb3a22 (Include hw/hw.h exactly where needed) 19/29 Checking commit 9db50e648257 (Include qemu/queue.h slightly less) 20/29 Checking commit dbce1e2e0b80 (Include qemu/main-loop.h less) 21/29 Checking commit c72a86b86161 (Include hw/qdev-properties.h less) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #5719: deleted file mode 100644 total: 0 errors, 1 warnings, 3640 lines checked Patch 21/29 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 22/29 Checking commit 9114ff0ca0cc (Include hw/boards.h a bit less) 23/29 Checking commit 7b81864ec937 (numa: Don't include hw/boards.h into sysemu/numa.h) 24/29 Checking commit 28ea9704a673 (Include sysemu/hostmem.h less) 25/29 Checking commit 0ade0fa06922 (numa: Move remaining NUMA declarations from sysemu.h to numa.h) 26/29 Checking commit 1f543764c6a4 (Clean up inclusion of sysemu/sysemu.h) 27/29 Checking commit 67065f53b9ad (Include sysemu/sysemu.h a lot less) 28/29 Checking commit 436bf3a37069 (sysemu: Move the VMChangeStateEntry typedef to qemu/typedefs.h) 29/29 Checking commit 677e4b3d176e (sysemu: Split sysemu/runstate.h off sysemu/sysemu.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #1331: new file mode 100644 total: 0 errors, 1 warnings, 1342 lines checked Patch 29/29 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190806151435.10740-1-arm...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com