Re: [Qemu-devel] [PATCH v4 30/54] translator: add translator_ld{ub, sw, uw, l, q}

[Richard Henderson]

On 7/31/19 9:06 AM, Alex Bennée wrote:
> +#ifdef CONFIG_USER_ONLY
> +
> +#define DO_LOAD(type, name, shift)               \
> +    set_helper_retaddr(1);                       \
> +    ret = name ## _p(g2h(pc));                   \
> +    clear_helper_retaddr();
> +
> +#else
> +
> +#define DO_LOAD(type, name, shift)                   \
> +    int mmu_idx = cpu_mmu_index(env, true);          \
> +    TCGMemOpIdx oi = make_memop_idx(shift, mmu_idx); \
> +    ret = helper_ret_ ## name ## _cmmu(env, pc, oi, 0);

Why are you only using the out-of-line slowpath functions?
Seems like the rest of the fastpath should be included too.


r~