On Wed, Jul 31, 2019 at 06:27:16PM +0100, Dr. David Alan Gilbert wrote: > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > fdopendir(3) takes ownership of the file descriptor. The presence of > > the lo_dirp->fd field could lead to someone incorrectly adding a > > close(d->fd) cleanup call in the future. > > > > Do not store the file descriptor in struct lo_dirp since it is unused. > > > > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> > > Reviewed-by: Dr. David Alan Gilbert <dgilb...@redhat.com> > > > Thanks, applied; note: > a) This looks like it can go into upstream libfuse > b) I think we're probably leaking DIR *'s if we do an lo_shutdown; > I've added that to my todo
FUSE_DESTROY is current broken, it leaks resources and is not thread-safe. It's something I'll tackle in multithreading preparation part 3. Stefan
signature.asc
Description: PGP signature
