On Mon, Jul 29, 2019 at 09:04:01AM +0200, Igor Mammedov wrote:
>On Sun, 28 Jul 2019 21:13:03 +0800
>Wei Yang <richardw.y...@linux.intel.com> wrote:
>
>> When there is no hint, the first un-overlapped range is the proper one.
>> Just break the loop instead of iterate the whole list.
>could it change default pc-dimm mapping (will address assignment stay
>the same as before this change)?
Yes, it stays the same as before.
>
>In commit message I'd suggest to replace 'the proper one' with more
>verbose explanation why it is safe to break earlier.
>
ok, let me re-phrase it. Thanks
>otherwise patch look good to me
>
>>
>> Signed-off-by: Wei Yang <richardw.y...@linux.intel.com>
>> ---
>> hw/mem/memory-device.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/hw/mem/memory-device.c b/hw/mem/memory-device.c
>> index df3261b32a..413b514586 100644
>> --- a/hw/mem/memory-device.c
>> +++ b/hw/mem/memory-device.c
>> @@ -180,6 +180,8 @@ static uint64_t memory_device_get_free_addr(MachineState
>> *ms,
>> range_make_empty(&new);
>> break;
>> }
>> + } else if (!hint) {
>> + break;
>> }
>> }
>>
--
Wei Yang
Help you, Help me
