On 7/15/19 7:40 AM, Max Reitz wrote:
> On 09.07.19 00:05, John Snow wrote:
>> It is used to do transactional movement of the bitmap (which is
>> possible in conjunction with merge command). Transactional bitmap
>> movement is needed in scenarios with external snapshot, when we don't
>> want to leave copy of the bitmap in the base image.
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <[email protected]>
>> Signed-off-by: John Snow <[email protected]>
>> ---
>> block.c | 2 +-
>> block/dirty-bitmap.c | 15 +++----
>> blockdev.c | 79 +++++++++++++++++++++++++++++++---
>> include/block/dirty-bitmap.h | 2 +-
>> migration/block-dirty-bitmap.c | 2 +-
>> qapi/transaction.json | 2 +
>> 6 files changed, 85 insertions(+), 17 deletions(-)
>
> [...]
>
>> diff --git a/qapi/transaction.json b/qapi/transaction.json
>> index 95edb78227..da95b804aa 100644
>> --- a/qapi/transaction.json
>> +++ b/qapi/transaction.json
>> @@ -45,6 +45,7 @@
>> #
>> # - @abort: since 1.6
>> # - @block-dirty-bitmap-add: since 2.5
>> +# - @block-dirty-bitmap-remove: since 4.1
>
> Optimistic.
>
> But anyway:
>
> Reviewed-by: Max Reitz <[email protected]>
>
>> # - @block-dirty-bitmap-clear: since 2.5
>> # - @block-dirty-bitmap-enable: since 4.0
>> # - @block-dirty-bitmap-disable: since 4.0
>
Hah, oops. OK, I'll adjust that (and your comment in patch 3) and stage
them.
Thank you!
