Patchew URL: https://patchew.org/QEMU/[email protected]/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v22 00/22] Add RX archtecture support Message-id: [email protected] === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' 5c31c30 target/rx: remove unused functions. 308fe3f BootLinuxConsoleTest: Test the RX-Virt machine aad3fbb Add rx-softmmu 75e7452 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core fbdf7ad hw/rx: Honor -accel qtest 6332318 hw/rx: RX Target hardware definition 4fb12bc hw/char: RX62N serial communication interface (SCI) ff11a0d hw/timer: RX62N internal timer modules b40f5b0 hw/intc: RX62N interrupt controller (ICUa) d89af76 target/rx: Dump bytes for each insn during disassembly 1986f48 target/rx: Collect all bytes during disassembly 1c5a800 target/rx: Emit all disassembly in one prt() 5ee3296 target/rx: Use prt_ldmi for XCHG_mr disassembly 2970dd5 target/rx: Replace operand with prt_ldmi in disassembler f685d62 target/rx: Disassemble rx_index_addr into a string 14f4a89 target/rx: RX disassembler 48090c8 target/rx: CPU definition ab6ad65 target/rx: TCG helper a8ffda1 target/rx: TCG translation 4f57e38 hw/registerfields.h: Add 8bit and 16bit register macros ad6d108 qemu/bitops.h: Add extract8 and extract16 da0b865 MAINTAINERS: Add RX === OUTPUT BEGIN === 1/22 Checking commit da0b865da945 (MAINTAINERS: Add RX) 2/22 Checking commit ad6d1082803e (qemu/bitops.h: Add extract8 and extract16) 3/22 Checking commit 4f57e3834e2d (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2467. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 3/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/22 Checking commit a8ffda140514 (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 4/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/22 Checking commit ab6ad652a680 (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #25: new file mode 100644 total: 0 errors, 1 warnings, 649 lines checked Patch 5/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/22 Checking commit 48090c8d253d (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #29: new file mode 100644 total: 0 errors, 1 warnings, 622 lines checked Patch 6/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/22 Checking commit 14f4a8973e07 (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 7/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/22 Checking commit f685d6247c8f (target/rx: Disassemble rx_index_addr into a string) 9/22 Checking commit 2970dd537949 (target/rx: Replace operand with prt_ldmi in disassembler) 10/22 Checking commit 5ee3296eff91 (target/rx: Use prt_ldmi for XCHG_mr disassembly) 11/22 Checking commit 1c5a80035379 (target/rx: Emit all disassembly in one prt()) 12/22 Checking commit 1986f486e83a (target/rx: Collect all bytes during disassembly) 13/22 Checking commit d89af7691926 (target/rx: Dump bytes for each insn during disassembly) 14/22 Checking commit b40f5b0cbd9a (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 14/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/22 Checking commit ff11a0d1ac3e (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 839 lines checked Patch 15/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/22 Checking commit 4fb12bc99962 (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 16/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/22 Checking commit 6332318fd7d5 (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #26: new file mode 100644 total: 0 errors, 1 warnings, 479 lines checked Patch 17/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/22 Checking commit fbdf7ad2b118 (hw/rx: Honor -accel qtest) 19/22 Checking commit 75e74524c726 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 20/22 Checking commit aad3fbbe2c3e (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #61: new file mode 100644 total: 0 errors, 1 warnings, 73 lines checked Patch 20/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/22 Checking commit 308fe3f8510b (BootLinuxConsoleTest: Test the RX-Virt machine) 22/22 Checking commit 5c31c30565ff (target/rx: remove unused functions.) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: deleted file mode 100644 total: 0 errors, 1 warnings, 5 lines checked Patch 22/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/[email protected]/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to [email protected]
