Paolo Bonzini <pbonz...@redhat.com> writes:
> While indeed we do not want to have
>
> return (a);
>
> it is less clear that this applies to
>
> return (a &&
> b);
>
> Some editors indent more nicely if you have parentheses, and some people's
> eyes may appreciate that as well.
No objection.
> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
> ---
> scripts/checkpatch.pl | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index c2aaf42..2f81371 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2296,7 +2296,8 @@ sub process {
> $value =~ s/\([^\(\)]*\)/1/) {
> }
> #print "value<$value>\n";
> - if ($value =~ /^\s*(?:$Ident|-?$Constant)\s*$/) {
> + if ($value =~ /^\s*(?:$Ident|-?$Constant)\s*$/ &&
> + $line =~ /;$/) {
> ERROR("return is not a function, parentheses
> are not required\n" . $herecurr);
>
> } elsif ($spacing !~ /\s+/) {
