On Wed, 2019-06-05 at 07:58 +0200, Markus Armbruster wrote: > Aarushi Mehta <[email protected]> writes: > > > Option only enumerates for hosts that support it. > > Blank line here, please. Same in other patches. > > > Signed-off-by: Aarushi Mehta <[email protected]> > > --- > > qapi/block-core.json | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/qapi/block-core.json b/qapi/block-core.json > > index 1defcde048..db7eedd058 100644 > > --- a/qapi/block-core.json > > +++ b/qapi/block-core.json > > @@ -2792,11 +2792,13 @@ > > # > > # @threads: Use qemu's thread pool > > # @native: Use native AIO backend (only Linux and Windows) > > +# @io_uring: Use linux io_uring (since 4.1) > > # > > # Since: 2.9 > > ## > > { 'enum': 'BlockdevAioOptions', > > - 'data': [ 'threads', 'native' ] } > > + 'data': [ 'threads', 'native', > > + { 'name': 'io_uring', 'if': 'defined(CONFIG_LINUX_IO_URING)' } > > ] } > > We prefer '-' over '_' in the QAPI schema: 'io-uring' instead of > 'io_uring'. Exceptions can be made when existing siblings use '_' (not > the case here), or to match how the thing is commonly spelled outside > QEMU. Up to the subject matter experts; I just want to make sure it's > not accidental
I agree with that. Other than that, Reviewed-by: Maxim Levitsky <[email protected]> Best regards, Maxim Levitsky
