On 5/31/19 5:44 AM, David Hildenbrand wrote:
> +static DisasJumpType op_vcdg(DisasContext *s, DisasOps *o)
> +{
> + const uint8_t fpf = get_field(s->fields, m3);
> + const uint8_t m4 = get_field(s->fields, m4);
> + const uint8_t erm = get_field(s->fields, m5);
> + const bool se = extract32(m4, 3, 1);
> + gen_helper_gvec_2_ptr *fn;
> +
> + if (fpf != FPF_LONG || extract32(m4, 0, 2) || erm > 7 || erm == 2) {
Please split out the erm validity check.
We have fpinst_extract_m34 doing some of this now;
it would be a shame to replicate it more.
r~
