On 5/19/19 4:46 PM, Jakub Jermar wrote: > On 5/19/19 2:00 PM, Aleksandar Markovic wrote: >>>> >>>> * A fix for HelenOS boot hang (related to the flag PAGE_EXEC) >>> >>> This was rather a problem with failing non-executable page tests in >>> L4Re, not HelenOS. Even though I tested HelenOS for regressions. >> >> OK, Jakub, what would be your suggestion for a high-level description >> of this message for end users (it is definitely a change that affects end >> user)? Something like" Improved PAGE_EXEC flag handling"? > > It makes sure that referenced pages are not automatically marked > executable by QEMU (despite the XI bit). > > As a user-visible change, this might unbreak some tests that attempt to > execute data. Note that this fix does not affect pages that are not > referenced prior to being executed - those have worked fine. > > Otherwise for normal code that does not attempt to execute data, things > should not change at all.
Yes. > > Cheers, > Jakub > >> Thanks, >> Aleksandar Thanks Aleksandar for preparing this pull request! Phil.
