On 5/7/19 7:13 AM, Laurent Vivier wrote:
>> - if (seed_optarg != NULL) {
>> - qemu_guest_random_seed_main(seed_optarg, &error_fatal);
>> + {
>> + Error *err = NULL;
>> + if (seed_optarg != NULL) {
>> + qemu_guest_random_seed_main(seed_optarg, &err);
>> + } else {
>> + /* ??? Assumes qcrypto is only used by qemu_guest_getrandom. */
>
> perhaps you can add a qemu_guest_random_init() function close to this
> assumption to call qcrypto_init()? So we will not forget to change this if we
> use something else in the future.
I'm not sure what you're suggesting.
Why would putting qcrypto_init within qemu_guest_random_init make it more
likely that, if something else within linux-user required qcrypto routines, we
would remember to remove qemu_guest_random_init and call qcrypto_init exactly
once?
r~
