On 5/7/19 3:37 PM, Peter Maydell wrote: > I just ran into this test failure: > > PYTHONPATH=/home/linux1/qemu/scripts python3 -B > /home/linux1/qemu/tests/qapi-schema/test-qapi.py > /home/linux1/qemu/tests/qapi-schema/unicode-str.json >> tests/qapi-schema/unicode-str.test.out > 2>tests/qapi-schema/unicode-str.test.err; echo $? >> tests/qapi-schema/unicode-str.test.exit > --- /home/linux1/qemu/tests/qapi-schema/unicode-str.err 2017-07-06 > 10:23:13.601812330 -0400 > +++ - 2019-05-07 18:32:31.533125931 -0400 > @@ -1 +1 @@ > -tests/qapi-schema/unicode-str.json:2: 'command' uses invalid name 'é' > +tests/qapi-schema/unicode-str.json:2: 'command' uses invalid name '\xe9' > /home/linux1/qemu/tests/Makefile.include:1105: recipe for target > 'check-tests/qapi-schema/unicode-str.json' failed > make: *** [check-tests/qapi-schema/unicode-str.json] Error 1 > make: Leaving directory '/home/linux1/qemu/build/all' > > but oddly only when I ran 'make check' by logging directly > into this machine (usually I run the tests automatically > via ssh and scripting), which suggests it may depend > on the locale settings. Does anybody recognize this ? > I think LANG=C fails, but LANG=C.UTF-8 passes. > > Ideally our test suite should not depend on the locale > or environment settings of the user running it.
Yes, there's an active thread about this: https://lists.gnu.org/archive/html/qemu-devel/2019-05/msg01247.html r~
