On 07/05/2019 01:48, Anton Blanchard wrote:
> We were using set_cpu_vsr* when we should have used set_cpu_vsrl*
>
> Fixes: 8b3b2d75c7c0 ("introduce get_cpu_vsr{l,h}() and set_cpu_vsr{l,h}()
> helpers for VSR register access")
> Signed-off-by: Anton Blanchard <[email protected]>
> ---
> target/ppc/translate/vsx-impl.inc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target/ppc/translate/vsx-impl.inc.c
> b/target/ppc/translate/vsx-impl.inc.c
> index c13f84e745..0a48020e3b 100644
> --- a/target/ppc/translate/vsx-impl.inc.c
> +++ b/target/ppc/translate/vsx-impl.inc.c
> @@ -859,8 +859,8 @@ static void glue(gen_, name)(DisasContext *ctx)
> \
> xbh = tcg_temp_new_i64(); \
> xbl = tcg_temp_new_i64(); \
> sgm = tcg_temp_new_i64(); \
> - set_cpu_vsrh(xB(ctx->opcode), xbh); \
> - set_cpu_vsrl(xB(ctx->opcode), xbl); \
> + get_cpu_vsrh(xbh, xB(ctx->opcode)); \
> + get_cpu_vsrl(xbl, xB(ctx->opcode)); \
> tcg_gen_movi_i64(sgm, sgn_mask); \
> switch (op) { \
> case OP_ABS: { \
With the typo in the subject line fixed:
Reviewed-by: Mark Cave-Ayland <[email protected]>
ATB,
Mark.
