On 30/04/2019 17:38, Richard Henderson wrote:
> On 4/28/19 7:38 AM, Mark Cave-Ayland wrote:
>> +#define GEN_VSX_HELPER_X2(name, op1, op2, inval, type)
>> \
>> +static void gen_##name(DisasContext *ctx)
>> \
>> +{
>> \
>> + TCGv_i32 opc;
>> \
>> + TCGv_ptr xt, xb;
>> \
>> + if (unlikely(!ctx->vsx_enabled)) {
>> \
>> + gen_exception(ctx, POWERPC_EXCP_VSXU);
>> \
>> + return;
>> \
>> + }
>> \
>> + opc = tcg_const_i32(ctx->opcode);
>> \
>> + xt = gen_vsr_ptr(xT(ctx->opcode));
>> \
>> + xb = gen_vsr_ptr(xB(ctx->opcode));
>> \
>> + gen_helper_##name(cpu_env, opc, xt, xb);
>> \
>
> Similarly wrt opc. However,
>
> Reviewed-by: Richard Henderson <[email protected]>
For reference the culprits here is helper_xscvqpdp(). But again if you agree
that it
makes sense to create separate gen/helper functions then I can remove the opcode
later on in the series.
ATB,
Mark.
