On Fri, May 03, 2019 at 06:41:43PM +0200, Thomas Huth wrote:
> On 03/05/2019 02.41, Eduardo Habkost wrote:
> > From: Daniel P. Berrangé <[email protected]>
> >
> > Unless overridden via an env var or configure arg, QEMU will only look
> > for the 'python' binary in $PATH. This is unhelpful on distros which
> > are only shipping Python 3.x (eg Fedora) in their default install as,
> > if they comply with PEP 394, the bare 'python' binary won't exist.
> >
> > This changes configure so that by default it will search for all three
> > common python binaries, preferring to find Python 3.x versions.
> >
> > Signed-off-by: Daniel P. Berrangé <[email protected]>
> > Message-Id: <[email protected]>
> > Signed-off-by: Eduardo Habkost <[email protected]>
> > ---
> > configure | 18 +++++++++++++++---
> > 1 file changed, 15 insertions(+), 3 deletions(-)
>
> I haven't bisected it, but I think this patch here broke the gitlab-ci tests:
>
> https://gitlab.com/huth/qemu/-/jobs/206806257
>
> Seems like the test is now failing when you don't have an UTF-8 locale:
>
> LANG=C make check-qapi-schema
I couldn't reproduce it this way, probably because I'm running Python 3.7 which
implements PEP 538 ("Coercing the legacy C locale to a UTF-8 based locale").
But I can force it to break using:
PYTHONIOENCODING=ascii make check-qapi-schema
> [...]
> TEST tests/qapi-schema/union-base-empty.out
> --- /builds/huth/qemu/tests/qapi-schema/unicode-str.err 2019-05-03
> 15:21:39.000000000 +0000
> +++ - 2019-05-03 15:42:01.561762978 +0000
> @@ -1 +1 @@
> -tests/qapi-schema/unicode-str.json:2: 'command' uses invalid name 'é'
> +tests/qapi-schema/unicode-str.json:2: 'command' uses invalid name '\xe9'
> /builds/huth/qemu/tests/Makefile.include:1105: recipe for target
> 'check-tests/qapi-schema/unicode-str.json' failed
> make: *** [check-tests/qapi-schema/unicode-str.json] Error 1
>
> Any ideas how to fix this?
Probably we just need to specify an explicit encoding at the statement that
prints the error message to stderr. I will give it a try.
--
Eduardo
