On Tue, 30 Apr 2019 15:30:31 +0800 Like Xu <[email protected]> wrote:
> On 2019/4/4 22:25, Igor Mammedov wrote: > > On Fri, 29 Mar 2019 16:48:38 +0800 > > Like Xu <[email protected]> wrote: > > [...] > > The division of responsibility for this case (refactoring > qemu_init_vcpu) seems to be a poisonous apple. > > The prerequisite for setting cpu-> nr_cores / nr_threads from the parent > is that the CPU has been created, so if any process during > initialization needs this topo information, it will use the default > values form cpu_common_initfn() instead of user-configured parameters. can you point to concrete place that needs access to nr_cores / nr_threads before cpu is 'realized'? > We may not want to repeat those assignment operations using the new > values and what do you think, Igor? > > <snipp> >
