On Thu, Apr 25, 2019 at 11:54:34AM -0300, Wainer dos Santos Moschetta wrote:
> Hi Eduardo,
>
> On 04/23/2019 06:22 PM, Eduardo Habkost wrote:
[...]
> > +class QueryMachines(Test):
> > + def test(self):
>
> I suggest to use a meaning test case name as it will be displayed with
> Avocado output. Something like 'test_status_information'.
This is a generic test case for query-machines, and I don't
expect it to be specific for validating support-status.
>
> > + self.vm.launch()
> > + machines = self.vm.command('query-machines')
>
> Also I suggest to assert you got at least on machine, so ensure
> 'query-machines' returning nothing doesn't pass unnoticed.
Good idea. I will send this in v2 or as a follow up patch.
Thanks!
--
Eduardo
