On Tue, 9 Apr 2019 17:58:31 +0200 Eric Auger <[email protected]> wrote:
> The code used to assign an interrupt index/subindex to an > eventfd is duplicated many times. Let's introduce an helper that > allows to set/unset the signaling for an ACTION_TRIGGER or > ACTION_UNMASK action. I like that, and it looks like ccw can use the new function as well. (I can do a patch on top.) > > Signed-off-by: Eric Auger <[email protected]> > > --- > > This is a follow-up to > [PATCH v2 0/2] vfio-pci: Introduce vfio_set_event_handler(). > It looks to me that introducing vfio_set_irq_signaling() has more > benefits in term of code reduction and the helper abstraction > looks cleaner. > --- > hw/vfio/common.c | 61 +++++++++ > hw/vfio/pci.c | 224 ++++++++-------------------------- > hw/vfio/platform.c | 55 +++------ > include/hw/vfio/vfio-common.h | 2 + > 4 files changed, 134 insertions(+), 208 deletions(-) Reviewed-by: Cornelia Huck <[email protected]>
