On Thu, Apr 04, 2019 at 10:21:26AM -0500, Mark Kanda wrote: > From: Chris Kenna <[email protected]> > > In situations where e1000 receives an undersized Ethernet frame, > QEMU increments the emulated "Receive Undersize Count (RUC)" > register when padding the frame. > > This is incorrect because this an expected scenario (e.g. with > VLAN tag stripping) and not an error. As such, QEMU should not > increment the emulated RUC. > > Fixes: 3b2743017749 ("e1000: Implementing various counters") > > Reviewed-by: Mark Kanda <[email protected]> > Reviewed-by: Bhavesh Davda <[email protected]> > Signed-off-by: Chris Kenna <[email protected]> > --- > hw/net/e1000.c | 1 - > 1 file changed, 1 deletion(-)
CCing Jason. LGTM, if we don't discard it, we shouldn't increase the RUC counter. Reviewed-by: Stefano Garzarella <[email protected]> Thanks, Stefano
