Thanks for the feedback! I have recreated the patch according to Daniels suggestions by separating the modifications.
On Mon, 1 Apr 2019 at 18:25, Eric Blake <ebl...@redhat.com> wrote: > On 4/1/19 4:26 AM, Aruna Jayasena wrote: > > Declarations were moved out of qemu-common.h for functions declared in > utils/ files. > > This task was under https://wiki.qemu.org/Contribute/BiteSizedTasks > > > > Signed-off-by: Aruna Jayasena <aruna...@cse.mrt.ac.lk> > > > > --- > > Thanks for working on this! Some hints for better reviews: > > - you sent a series, but did not include a 0/2 cover letter; our > automated CI tools do best when there is a cover letter > > - you did not describe how v2 differs from v1; here after the --- is a > good spot to mention it, to help reviewers double-check your changes from > v1 > > More patch submission hints can be found at > https://wiki.qemu.org/Contribute/SubmitAPatch > > -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3226 > Virtualization: qemu.org | libvirt.org > > -- *Aruna* Jayasena Embedded Systems and Computer Science Engineering Undergraduate University of Moratuwa *✆ **+94719872152 * ✉ <aruna...@cse.mrt.ac.lk> ⌨ <http://archfx.github.io> in <https://www.linkedin.com/in/arunajayasena/>
