On Fri, 29 Mar 2019 21:01:04 +1100 David Gibson <da...@gibson.dropbear.id.au> wrote:
> On Fri, Mar 29, 2019 at 10:37:08AM +0100, BALATON Zoltan wrote: > > On Fri, 29 Mar 2019, David Gibson wrote: > > > From: Greg Kurz <gr...@kaod.org> > > > > > > Signed-off-by: Greg Kurz <gr...@kaod.org> > > > Message-Id: <155359567174.1794128.3183997593369465355.st...@bahia.lan> > > > Signed-off-by: David Gibson <da...@gibson.dropbear.id.au> > > > --- > > > target/ppc/translate.c | 10 +++++++++- > > > 1 file changed, 9 insertions(+), 1 deletion(-) > > > > > > diff --git a/target/ppc/translate.c b/target/ppc/translate.c > > > index 576210d901..badc1ae1a3 100644 > > > --- a/target/ppc/translate.c > > > +++ b/target/ppc/translate.c > > > @@ -3753,7 +3753,15 @@ static void gen_bcond(DisasContext *ctx, int type) > > > * All ISAs up to v3 describe this form of bcctr as invalid > > > but > > > * some processors, ie. 64-bit server processors compliant > > > with > > > * arch 2.x, do implement a "test and decrement" logic > > > instead, > > > - * as described in their respective UMs. > > > + * as described in their respective UMs. This logic involves > > > CTR > > > > Shouldn't this have been squashed in patch 2 where this comment is added > > instead of modifying it right away? > > Drat, I didn't spot that. It's not ideal but I don't think it's worth > respinning the pull request for. > My bad, I wanted to suggest David to do just that and then I forgot when posting :-\
pgpq2Pm5LDsPW.pgp
Description: OpenPGP digital signature
