Hi On Mon, Mar 25, 2019 at 7:58 PM Eric Blake <ebl...@redhat.com> wrote: > > On 3/25/19 1:50 PM, Eric Blake wrote: > > On 3/25/19 1:04 PM, Marc-André Lureau wrote: > >> The slirp project is now hosted on freedesktop at: > >> https://gitlab.freedesktop.org/slirp. > >> > >> The libslirp source tree there is based on current qemu/slirp filtered > >> through clang-format, and can thus be directly used through a > >> git submodule. > > > > Indeed, doing 'diff -ur slirp /path/to/libslirp.git' shows a lot of > > formatting differences. Is there an easy command to see that the > > contents of the two are identical modulo the formatting changes? > > Or put another way, what is the precise clang-format command to run on > qemu.git/slirp/, prior to doing my 'diff -ur /path/to/qemu.git/slirp > /path/to/libslirp.git'? And that formula should be in the commit message :)
I used clang-format *.c *.h with the attached .clang-format and version 7.0.1. It should be added upstream, so we can keep a consistent style: https://gitlab.freedesktop.org/slirp/libslirp/merge_requests/3 > > I don't care if you ran clang-format on every commit in the new > repository so that it has a cleaner git history over all commits that > got transferred (in fact, if you did, that's actually cool, as it will > make git history trawling in libslirp nicer), only that the current > state of the git repository and the current state of the new submodule > are easily correlated. > > -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3226 > Virtualization: qemu.org | libvirt.org > thanks -- Marc-André Lureau
.clang-format
Description: Binary data
