On 03/13/2019 12:27 PM, Jason J. Herne wrote:
On 3/13/19 12:21 PM, Cornelia Huck wrote:
On Wed, 13 Mar 2019 12:10:50 -0400
"Jason J. Herne" <[email protected]> wrote:
On 3/13/19 10:04 AM, Eric Farman wrote:
+static void run_readipl(SubChannelId schid)
+{
+ if (do_cio(schid, 0x00, CCW_FMT0)) {
+ panic("dasd-ipl: Failed to run Read IPL channel program");
Maybe add a newline here...
+ }
There are three places you are suggesting a newline. All of them
appear to be before an if
statement's closing brace. Can you explain why you feel these are
needed? I don't really
see any improvement in readability with these newlines.
Maybe not in the source code, but to the string printed by panic()? I
could agree to that :)
Doh! Of course! :-D Sorry, Eric.
That's okay! I should've been more clear, since you can't see my
screen... :-)
I had some bad kernel code and didn't like where my prompt ended up:
...snip...
cyl & head addr [0]=: 0x0000000000000000
cyl & head addr [1]=: 0x0000000000000000
cyl & head addr [2]=: 0x0000000000000000
dasd-ipl: Failed to run Read IPL channel program[user@host ~]#
