On Wed, 13 Mar 2019 13:24:48 +0000 Wei Yang <[email protected]> wrote:
> On Wed, Mar 13, 2019 at 01:30:39PM +0100, Igor Mammedov wrote: > >On Wed, 13 Mar 2019 12:42:50 +0800 > >Wei Yang <[email protected]> wrote: > > > >> This patch set tries to generalize MCFG table build process. > >> > >> [1]: use acpi_get_mcfg() to get necessary information to build MCFG > >> [2]: remove an unnecessary variable mcfg_start > >> [3]: Extract build_mcfg to aml-build.c > >> > >> Wei Yang (3): > >> hw/arm/virt-acpi-build: use acpi_get_mcfg() to calculate bus number > >> hw/arm/virt-acpi-build: remove unnecessary variable mcfg_start > >> hw/acpi: Extract build_mcfg > > > >I'd add ano more patch on top > >which converts from packed structure to build_append_int_noprefix() API > > > > You mean get rid of type AcpiTableMcfg, and write raw data to blob with > build_append_int_noprefix()? yes, > > I don't get the benefits of doing so. see commit 5d7a334f7 > >> > >> hw/acpi/aml-build.c | 30 ++++++++++++++++++++++++++++++ > >> hw/arm/virt-acpi-build.c | 27 ++++++++++----------------- > >> hw/i386/acpi-build.c | 36 +----------------------------------- > >> include/hw/acpi/aml-build.h | 6 ++++++ > >> 4 files changed, 47 insertions(+), 52 deletions(-) > >> > > >
